Skip to content

Fix bundle identifier#39

Merged
ng merged 1 commit intodevfrom
fix/bundle-id-update
Apr 10, 2026
Merged

Fix bundle identifier#39
ng merged 1 commit intodevfrom
fix/bundle-id-update

Conversation

@ng
Copy link
Copy Markdown
Contributor

@ng ng commented Apr 10, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Update bundle ID from com.sleepypod.ios to com.jonathanng.ios.sleepypod
  • Update test bundle ID to com.jonathanng.ios.sleepypod.tests
  • Update Logger subsystem references in Log.swift

Test plan

  • xcodegen generates successfully
  • Build and install on device to verify signing

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Summary by CodeRabbit

  • Chores
    • Updated app bundle identifiers and logging subsystem configuration to align with new naming conventions.

@ng @claude
Fix bundle identifier to com.jonathanng.ios.sleepypod
01664dd 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ng ng merged commit f2b659d into dev Apr 10, 2026
2 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9593c0d3-57b1-4c66-9ae7-e3af911da40d

📥 Commits

Reviewing files that changed from the base of the PR and between 58fca96 and 01664dd.

📒 Files selected for processing (2)
  • Sleepypod/Services/Log.swift
  • project.yml
📝 Walkthrough

Walkthrough

The pull request updates the iOS app bundle identifier scheme from com.sleepypod to com.jonathanng.ios.sleepypod across build configuration and logging subsystems. Changes include bundle ID prefix and target identifiers in project.yml, and logging subsystem values in Log.swift.

Changes

Cohort / File(s) Summary
Build Configuration
project.yml		 Updated options.bundleIdPrefix and PRODUCT_BUNDLE_IDENTIFIER settings for Sleepypod and SleepypodTests targets from com.sleepypod prefix to com.jonathanng.ios.sleepypod.
Logging Subsystem
Sleepypod/Services/Log.swift		 Updated subsystem identifier for all five Logger instances (network, discovery, device, general, sensor) from com.sleepypod.ios to com.jonathanng.ios.sleepypod. Also updated example log show predicate comment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Bundle identifiers now dance with new names,
From sleepypod to jonathanng.ios frames,
Each logger and target, renamed with care,
The app's new identity floats in the air! 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bundle-id-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ng